diff --git a/sys/net/if_spppsubr.c b/sys/net/if_spppsubr.c index 030dd94..ca3af79 100644 --- a/sys/net/if_spppsubr.c +++ b/sys/net/if_spppsubr.c @@ -4897,7 +4897,10 @@ found: *dest = new_dst; /* fix dstaddr in place */ } } + LIST_REMOVE(ifatoia(ifa), ia_hash); error = in_ifinit(ifp, ifatoia(ifa), &new_sin, 0, hostIsNew); + LIST_INSERT_HEAD(&IN_IFADDR_HASH(ifatoia(ifa)->ia_addr.sin_addr.s_addr), + ifatoia(ifa), ia_hash); if (debug && error) { log(LOG_DEBUG, "%s: sppp_set_ip_addrs: in_ifinit " @@ -4950,7 +4953,10 @@ found: if (sp->ipcp.flags & IPCP_HISADDR_DYN) /* replace peer addr in place */ dest->sin_addr.s_addr = sp->ipcp.saved_hisaddr; + LIST_REMOVE(ifatoia(ifa), ia_hash); in_ifinit(ifp, ifatoia(ifa), &new_sin, 0, 0); + LIST_INSERT_HEAD(&IN_IFADDR_HASH(ifatoia(ifa)->ia_addr.sin_addr.s_addr), + ifatoia(ifa), ia_hash); (void)pfil_run_hooks(if_pfil, (struct mbuf **)SIOCDIFADDR, ifp, PFIL_IFADDR); } diff --git a/sys/netinet/if_arp.c b/sys/netinet/if_arp.c index b32d4b1..f4810c7 100644 --- a/sys/netinet/if_arp.c +++ b/sys/netinet/if_arp.c @@ -589,6 +589,20 @@ arp_rtrequest(int req, struct rtentry *rt, const struct rt_addrinfo *info) if (rt->rt_flags & RTF_BROADCAST) break; + /* + * When called from rt_ifa_addlocal, we cannot depend on that + * the address (rt_getkey(rt)) exits in the address list of the + * interface. So check RTF_LOCAL instead. + */ + if (rt->rt_flags & RTF_LOCAL) { + rt->rt_expire = 0; + if (useloopback) { + rt->rt_ifp = lo0ifp; + rt->rt_rmx.rmx_mtu = 0; + } + break; + } + INADDR_TO_IA(satocsin(rt_getkey(rt))->sin_addr, ia); while (ia && ia->ia_ifp != ifp) NEXT_IA_WITH_SAME_ADDR(ia); diff --git a/sys/netinet/in.c b/sys/netinet/in.c index 7940a04..df34d58 100644 --- a/sys/netinet/in.c +++ b/sys/netinet/in.c @@ -359,6 +359,8 @@ in_control(struct socket *so, u_long cmd, void *data, struct ifnet *ifp) struct sockaddr_in oldaddr; int error, hostIsNew, maskIsNew; int newifaddr = 0; + bool run_hook = false; + bool need_reinsert = false; switch (cmd) { case SIOCALIFADDR: @@ -440,9 +442,6 @@ in_control(struct socket *so, u_long cmd, void *data, struct ifnet *ifp) ia = malloc(sizeof(*ia), M_IFADDR, M_WAITOK|M_ZERO); if (ia == NULL) return (ENOBUFS); - TAILQ_INSERT_TAIL(&in_ifaddrhead, ia, ia_list); - ifaref(&ia->ia_ifa); - ifa_insert(ifp, &ia->ia_ifa); ia->ia_ifa.ifa_addr = sintosa(&ia->ia_addr); ia->ia_ifa.ifa_dstaddr = sintosa(&ia->ia_dstaddr); ia->ia_ifa.ifa_netmask = sintosa(&ia->ia_sockmask); @@ -460,6 +459,7 @@ in_control(struct socket *so, u_long cmd, void *data, struct ifnet *ifp) ia->ia_ifp = ifp; ia->ia_idsalt = cprng_fast32() % 65535; LIST_INIT(&ia->ia_multiaddrs); + newifaddr = 1; } break; @@ -533,18 +533,24 @@ in_control(struct socket *so, u_long cmd, void *data, struct ifnet *ifp) break; case SIOCSIFADDR: + if (!newifaddr) { + LIST_REMOVE(ia, ia_hash); + need_reinsert = true; + } error = in_ifinit(ifp, ia, satocsin(ifreq_getaddr(cmd, ifr)), 1, hostIsNew); - if (error == 0) { - (void)pfil_run_hooks(if_pfil, - (struct mbuf **)SIOCSIFADDR, ifp, PFIL_IFADDR); - } + + run_hook = true; break; case SIOCSIFNETMASK: in_ifscrub(ifp, ia); ia->ia_sockmask = *satocsin(ifreq_getaddr(cmd, ifr)); ia->ia_subnetmask = ia->ia_sockmask.sin_addr.s_addr; + if (!newifaddr) { + LIST_REMOVE(ia, ia_hash); + need_reinsert = true; + } error = in_ifinit(ifp, ia, NULL, 0, 0); break; @@ -570,15 +576,17 @@ in_control(struct socket *so, u_long cmd, void *data, struct ifnet *ifp) } if (ifra->ifra_addr.sin_family == AF_INET && (hostIsNew || maskIsNew)) { + if (!newifaddr) { + LIST_REMOVE(ia, ia_hash); + need_reinsert = true; + } error = in_ifinit(ifp, ia, &ifra->ifra_addr, 0, hostIsNew); } if ((ifp->if_flags & IFF_BROADCAST) && (ifra->ifra_broadaddr.sin_family == AF_INET)) ia->ia_broadaddr = ifra->ifra_broadaddr; - if (error == 0) - (void)pfil_run_hooks(if_pfil, - (struct mbuf **)SIOCAIFADDR, ifp, PFIL_IFADDR); + run_hook = true; break; case SIOCGIFALIAS: @@ -600,8 +608,7 @@ in_control(struct socket *so, u_long cmd, void *data, struct ifnet *ifp) case SIOCDIFADDR: in_purgeaddr(&ia->ia_ifa); - (void)pfil_run_hooks(if_pfil, (struct mbuf **)SIOCDIFADDR, - ifp, PFIL_IFADDR); + run_hook = true; break; #ifdef MROUTING @@ -615,7 +622,26 @@ in_control(struct socket *so, u_long cmd, void *data, struct ifnet *ifp) return ENOTTY; } - if (error != 0 && newifaddr) { + /* + * XXX insert regardless of error to make in_purgeaddr below work. + * Need to improve. + */ + if (newifaddr) { + TAILQ_INSERT_TAIL(&in_ifaddrhead, ia, ia_list); + ifaref(&ia->ia_ifa); + ifa_insert(ifp, &ia->ia_ifa); + LIST_INSERT_HEAD(&IN_IFADDR_HASH(ia->ia_addr.sin_addr.s_addr), + ia, ia_hash); + } else if (need_reinsert) { + LIST_INSERT_HEAD(&IN_IFADDR_HASH(ia->ia_addr.sin_addr.s_addr), + ia, ia_hash); + } + + if (error == 0) { + if (run_hook) + (void)pfil_run_hooks(if_pfil, + (struct mbuf **)cmd, ifp, PFIL_IFADDR); + } else if (newifaddr) { KASSERT(ia != NULL); in_purgeaddr(&ia->ia_ifa); } @@ -908,10 +934,7 @@ in_ifinit(struct ifnet *ifp, struct in_ifaddr *ia, * Set up new addresses. */ oldaddr = ia->ia_addr; - if (ia->ia_addr.sin_family == AF_INET) - LIST_REMOVE(ia, ia_hash); ia->ia_addr = *sin; - LIST_INSERT_HEAD(&IN_IFADDR_HASH(ia->ia_addr.sin_addr.s_addr), ia, ia_hash); /* Set IN_IFF flags early for if_addr_init() */ if (hostIsNew && if_do_dad(ifp) && !in_nullhost(ia->ia_addr.sin_addr)) { @@ -1002,11 +1025,7 @@ in_ifinit(struct ifnet *ifp, struct in_ifaddr *ia, return (error); bad: splx(s); - LIST_REMOVE(ia, ia_hash); ia->ia_addr = oldaddr; - if (ia->ia_addr.sin_family == AF_INET) - LIST_INSERT_HEAD(&IN_IFADDR_HASH(ia->ia_addr.sin_addr.s_addr), - ia, ia_hash); return (error); } diff --git a/sys/netinet6/in6.c b/sys/netinet6/in6.c index ed9d8e5..b81652e 100644 --- a/sys/netinet6/in6.c +++ b/sys/netinet6/in6.c @@ -921,16 +921,6 @@ in6_update_ifa1(struct ifnet *ifp, struct in6_aliasreq *ifra, (struct sockaddr *)&ia->ia_prefixmask; ia->ia_ifp = ifp; - if ((oia = in6_ifaddr) != NULL) { - for ( ; oia->ia_next; oia = oia->ia_next) - continue; - oia->ia_next = ia; - } else - in6_ifaddr = ia; - /* gain a refcnt for the link from in6_ifaddr */ - ifaref(&ia->ia_ifa); - - ifa_insert(ifp, &ia->ia_ifa); } /* update timestamp */ @@ -950,7 +940,9 @@ in6_update_ifa1(struct ifnet *ifp, struct in6_aliasreq *ifra, " existing (%s) address should not be changed\n", ip6_sprintf(&ia->ia_addr.sin6_addr)); error = EINVAL; - goto unlink; + if (hostIsNew) + free(ia, M_IFADDR); + goto exit; } ia->ia_prefixmask = ifra->ifra_prefixmask; } @@ -1020,8 +1012,12 @@ in6_update_ifa1(struct ifnet *ifp, struct in6_aliasreq *ifra, } /* reset the interface and routing table appropriately. */ - if ((error = in6_ifinit(ifp, ia, &ifra->ifra_addr, hostIsNew)) != 0) - goto unlink; + if ((error = in6_ifinit(ifp, ia, &ifra->ifra_addr, hostIsNew)) != 0) { + if (hostIsNew) + free(ia, M_IFADDR); + goto exit; + } + /* * We are done if we have simply modified an existing address. */ @@ -1029,6 +1025,19 @@ in6_update_ifa1(struct ifnet *ifp, struct in6_aliasreq *ifra, return error; /* + * Insert ia to the global list and ifa to the interface's list. + */ + if ((oia = in6_ifaddr) != NULL) { + for ( ; oia->ia_next; oia = oia->ia_next) + continue; + oia->ia_next = ia; + } else + in6_ifaddr = ia; + /* gain a refcnt for the link from in6_ifaddr */ + ifaref(&ia->ia_ifa); + ifa_insert(ifp, &ia->ia_ifa); + + /* * Beyond this point, we should call in6_purgeaddr upon an error, * not just go to unlink. */ @@ -1271,13 +1280,13 @@ in6_update_ifa1(struct ifnet *ifp, struct in6_aliasreq *ifra, return error; - unlink: /* * XXX: if a change of an existing address failed, keep the entry * anyway. */ if (hostIsNew) in6_unlink_ifa(ia, ifp); + exit: return error; cleanup: @@ -1695,7 +1704,7 @@ in6_ifinit(struct ifnet *ifp, struct in6_ifaddr *ia, ia->ia_addr = *sin6; - if (ifacount <= 1 && + if (ifacount <= 0 && (error = if_addr_init(ifp, &ia->ia_ifa, true)) != 0) { splx(s); return error; diff --git a/sys/netinet6/nd6.c b/sys/netinet6/nd6.c index 6b2a5b2..d1f0ae6 100644 --- a/sys/netinet6/nd6.c +++ b/sys/netinet6/nd6.c @@ -1450,6 +1450,17 @@ nd6_rtrequest(int req, struct rtentry *rt, const struct rt_addrinfo *info) RT_DPRINTF("rt_getkey(rt) = %p\n", rt_getkey(rt)); /* + * When called from rt_ifa_addlocal, we cannot depend on that + * the address (rt_getkey(rt)) exits in the address list of the + * interface. So check RTF_LOCAL instead. + */ + if (rt->rt_flags & RTF_LOCAL) { + if (nd6_useloopback) + rt->rt_ifp = lo0ifp; /* XXX */ + break; + } + + /* * check if rt_getkey(rt) is an address assigned * to the interface. */