From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src Date: Wed, 31 Jul 2019 09:13:17 +0000 Module Name: src Committed By: mrg Date: Wed Jul 31 09:13:17 UTC 2019 Modified Files: src/distrib/sets/lists/modules: mi src/sys/dev/usb: files.usb if_axen.c if_axenreg.h if_cdce.c src/sys/modules: Makefile Added Files: src/sys/dev/usb: usbnet.c usbnet.h src/sys/modules/usbnet: Makefile Log Message: introduce a library of common code / backends to share code between USB ethernet drivers. usbnet.h introduces a new set of APIs to provide common solutions for these driver features: - USB endpoint pipe handling - rx and tx chain handling - generic handlers or support for several struct ifnet callbacks - MII bus locking - interrupt handling - partial autoconf handling: much of attach, and detach/activate can use common versions directly. currently, only axen(4) and cdce(4) are converted. the reductions in these drivers are quite significant: if_cdce.c is reduced from 1000 lines to 320 lines, and if_axen is reduced from 1902 lines to 1021 lines. add a "usbnet" module and make the if_axen module depend upon it. To generate a diff of this commit: cvs rdiff -u -r1.122 -r1.123 src/distrib/sets/lists/modules/mi cvs rdiff -u -r1.156 -r1.157 src/sys/dev/usb/files.usb cvs rdiff -u -r1.50 -r1.51 src/sys/dev/usb/if_axen.c cvs rdiff -u -r1.14 -r1.15 src/sys/dev/usb/if_axenreg.h cvs rdiff -u -r1.53 -r1.54 src/sys/dev/usb/if_cdce.c cvs rdiff -u -r0 -r1.1 src/sys/dev/usb/usbnet.c src/sys/dev/usb/usbnet.h cvs rdiff -u -r1.222 -r1.223 src/sys/modules/Makefile cvs rdiff -u -r0 -r1.1 src/sys/modules/usbnet/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Martin Husemann" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Wed, 31 Jul 2019 10:19:55 +0000 Module Name: src Committed By: martin Date: Wed Jul 31 10:19:55 UTC 2019 Modified Files: src/sys/dev/usb: files.usb Log Message: Make cdce depend on usbnet too To generate a diff of this commit: cvs rdiff -u -r1.157 -r1.158 src/sys/dev/usb/files.usb Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Wed, 31 Jul 2019 23:47:16 +0000 Module Name: src Committed By: mrg Date: Wed Jul 31 23:47:16 UTC 2019 Modified Files: src/sys/dev/usb: if_axen.c if_cdce.c usbnet.c usbnet.h Log Message: couple of minor API updates: - change the read/write register callbacks to have the same phy/reg order as the MII code. - add "mii_flags" param to usbnet_attach_ifp(). axe(4) wants it. also: - add usbnet debug code, sysctl node support - remove commented DPRINTF()s accidentally left in place - add usbnet_softc() - reorder some attach code to be consistent - re-add USBD_FORCE_SHORT_XFER for axen rx chain ride 9.99.2 bump. To generate a diff of this commit: cvs rdiff -u -r1.51 -r1.52 src/sys/dev/usb/if_axen.c cvs rdiff -u -r1.54 -r1.55 src/sys/dev/usb/if_cdce.c cvs rdiff -u -r1.1 -r1.2 src/sys/dev/usb/usbnet.c src/sys/dev/usb/usbnet.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Thu, 1 Aug 2019 00:10:22 +0000 Module Name: src Committed By: mrg Date: Thu Aug 1 00:10:22 UTC 2019 Modified Files: src/sys/dev/usb: if_aue.c if_auereg.h if_kue.c if_kuereg.h if_mue.c if_smsc.c if_smscvar.h if_udav.c if_udavreg.h if_url.c if_urndis.c Log Message: remove unused code and use common ethernet media code where equivalent. To generate a diff of this commit: cvs rdiff -u -r1.154 -r1.155 src/sys/dev/usb/if_aue.c cvs rdiff -u -r1.29 -r1.30 src/sys/dev/usb/if_auereg.h cvs rdiff -u -r1.96 -r1.97 src/sys/dev/usb/if_kue.c cvs rdiff -u -r1.22 -r1.23 src/sys/dev/usb/if_kuereg.h cvs rdiff -u -r1.50 -r1.51 src/sys/dev/usb/if_mue.c cvs rdiff -u -r1.45 -r1.46 src/sys/dev/usb/if_smsc.c cvs rdiff -u -r1.7 -r1.8 src/sys/dev/usb/if_smscvar.h cvs rdiff -u -r1.59 -r1.60 src/sys/dev/usb/if_udav.c cvs rdiff -u -r1.13 -r1.14 src/sys/dev/usb/if_udavreg.h cvs rdiff -u -r1.66 -r1.67 src/sys/dev/usb/if_url.c cvs rdiff -u -r1.21 -r1.22 src/sys/dev/usb/if_urndis.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Thu, 1 Aug 2019 01:19:21 +0000 Module Name: src Committed By: mrg Date: Thu Aug 1 01:19:21 UTC 2019 Modified Files: src/sys/dev/usb: if_axe.c Log Message: fix locking botch. To generate a diff of this commit: cvs rdiff -u -r1.102 -r1.103 src/sys/dev/usb/if_axe.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Nick Hudson" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sat, 3 Aug 2019 15:58:14 +0000 Module Name: src Committed By: skrll Date: Sat Aug 3 15:58:14 UTC 2019 Modified Files: src/sys/dev/usb: usbnet.c usbnet.h Log Message: Trailing white space To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/sys/dev/usb/usbnet.c src/sys/dev/usb/usbnet.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sun, 4 Aug 2019 08:59:13 +0000 Module Name: src Committed By: mrg Date: Sun Aug 4 08:59:13 UTC 2019 Modified Files: src/sys/dev/usb: if_axen.c if_cdce.c usbnet.c usbnet.h Log Message: - adjust usbnet interface to allow usbd_open_pipe_intr(), from the new comment: * if un_intr_buf is not NULL, use usbd_open_pipe_intr() not * usbd_open_pipe() for USBNET_ENDPT_INTR, with this buffer, * size, and interval. the standard handling is in usbnet.c, with a callback to deal with the interrupt it self. not fully tested, designed for if_aue.c and a few others not yet converted. - make usbhist for usbnet.c work, thanks paulg - usbnet_init_rx_tx() clears out all allocations upon failure now - add usbnet_ec() to get a pointer to the struct ethercom - add usbnet_{lock,unlock,owned}*() to lock/unlock the various locks and *owned*() for asserting welcome 9.99.3! To generate a diff of this commit: cvs rdiff -u -r1.52 -r1.53 src/sys/dev/usb/if_axen.c cvs rdiff -u -r1.55 -r1.56 src/sys/dev/usb/if_cdce.c cvs rdiff -u -r1.3 -r1.4 src/sys/dev/usb/usbnet.c src/sys/dev/usb/usbnet.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sun, 4 Aug 2019 09:03:46 +0000 Module Name: src Committed By: mrg Date: Sun Aug 4 09:03:46 UTC 2019 Modified Files: src/sys/dev/usb: if_axe.c if_ure.c if_urevar.h Log Message: convert axe(4) and ure(4) to usbnet. axe loses 838 lines (37%) and ure loses 716 lines (36%). To generate a diff of this commit: cvs rdiff -u -r1.103 -r1.104 src/sys/dev/usb/if_axe.c cvs rdiff -u -r1.14 -r1.15 src/sys/dev/usb/if_ure.c cvs rdiff -u -r1.3 -r1.4 src/sys/dev/usb/if_urevar.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sun, 4 Aug 2019 09:10:49 +0000 Module Name: src Committed By: mrg Date: Sun Aug 4 09:10:48 UTC 2019 Modified Files: src/sys/dev/usb: TODO Log Message: add a list of done/todo items to the shared ethernet driver code. To generate a diff of this commit: cvs rdiff -u -r1.46 -r1.47 src/sys/dev/usb/TODO Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sun, 4 Aug 2019 18:04:18 +0000 Module Name: src Committed By: mrg Date: Sun Aug 4 18:04:18 UTC 2019 Modified Files: src/sys/dev/usb: if_ure.c Log Message: move / re-add some headers to fix INET6 builds. To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16 src/sys/dev/usb/if_ure.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys Date: Tue, 6 Aug 2019 00:19:57 +0000 Module Name: src Committed By: mrg Date: Tue Aug 6 00:19:57 UTC 2019 Modified Files: src/sys/dev/usb: if_axe.c if_axen.c if_cdce.c if_ure.c usbnet.c usbnet.h src/sys/sys: param.h Log Message: extend usbnet to cope with if_upl, if_smsc, and if_umb needs: - usbnet_enqueue() can set mbuf flags and csum_data - usbnet_input() for non-ethernet based devices (upl, umb) - allow a complete override for ioctl() - remove converted list -- we have compiling and/or working patches for all the devices except for umb(4), will be merged as testing happens hopefully this is the last ABI change, though it may end up being extended for additional smsc(4) support. hello for real netbsd 9.99.3! To generate a diff of this commit: cvs rdiff -u -r1.104 -r1.105 src/sys/dev/usb/if_axe.c cvs rdiff -u -r1.54 -r1.55 src/sys/dev/usb/if_axen.c cvs rdiff -u -r1.56 -r1.57 src/sys/dev/usb/if_cdce.c cvs rdiff -u -r1.16 -r1.17 src/sys/dev/usb/if_ure.c cvs rdiff -u -r1.4 -r1.5 src/sys/dev/usb/usbnet.c src/sys/dev/usb/usbnet.h cvs rdiff -u -r1.601 -r1.602 src/sys/sys/param.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Tue, 6 Aug 2019 01:42:22 +0000 Module Name: src Committed By: mrg Date: Tue Aug 6 01:42:22 UTC 2019 Modified Files: src/sys/dev/usb: if_axe.c if_axen.c if_cdce.c if_ure.c usbnet.c Log Message: for ethernet usb network devices, print the mac addr in usbnet. To generate a diff of this commit: cvs rdiff -u -r1.105 -r1.106 src/sys/dev/usb/if_axe.c cvs rdiff -u -r1.55 -r1.56 src/sys/dev/usb/if_axen.c cvs rdiff -u -r1.57 -r1.58 src/sys/dev/usb/if_cdce.c cvs rdiff -u -r1.17 -r1.18 src/sys/dev/usb/if_ure.c cvs rdiff -u -r1.5 -r1.6 src/sys/dev/usb/usbnet.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Tue, 6 Aug 2019 01:44:24 +0000 Module Name: src Committed By: mrg Date: Tue Aug 6 01:44:24 UTC 2019 Modified Files: src/sys/dev/usb: files.usb Log Message: mark axe(4) and ure(4) as needing usbnet To generate a diff of this commit: cvs rdiff -u -r1.158 -r1.159 src/sys/dev/usb/files.usb Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Wed, 7 Aug 2019 01:47:18 +0000 Module Name: src Committed By: mrg Date: Wed Aug 7 01:47:18 UTC 2019 Modified Files: src/sys/dev/usb: usbnet.c Log Message: fix two issues, found by maya@ while testing urndis: - avoid an KASSERT() in usbnet_rx_tx_init() when called early - move the pmf and usb driver event calls out of the mii specific code, now suspend is able to work on them again. urndis port to usbnet works with additional ipv6 lossage that may indicate it doesn't work (not commited yet.) To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/dev/usb/usbnet.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "SAITOH Masanobu" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Wed, 7 Aug 2019 06:31:03 +0000 Module Name: src Committed By: msaitoh Date: Wed Aug 7 06:31:03 UTC 2019 Modified Files: src/sys/dev/usb: if_aue.c Log Message: Fix panic when setting multicast addresses. Write the hash table outside of ETHER_LOC()/ETHER_UNLOCK(). To generate a diff of this commit: cvs rdiff -u -r1.155 -r1.156 src/sys/dev/usb/if_aue.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Nick Hudson" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Wed, 7 Aug 2019 07:05:55 +0000 Module Name: src Committed By: skrll Date: Wed Aug 7 07:05:54 UTC 2019 Modified Files: src/sys/dev/usb: if_smsc.c Removed Files: src/sys/dev/usb: if_smscvar.h Log Message: Convert smsc(4) to usbnet To generate a diff of this commit: cvs rdiff -u -r1.46 -r1.47 src/sys/dev/usb/if_smsc.c cvs rdiff -u -r1.8 -r0 src/sys/dev/usb/if_smscvar.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Nick Hudson" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Wed, 7 Aug 2019 07:08:02 +0000 Module Name: src Committed By: skrll Date: Wed Aug 7 07:08:02 UTC 2019 Modified Files: src/sys/dev/usb: TODO Log Message: Note that smsc(4) is done To generate a diff of this commit: cvs rdiff -u -r1.47 -r1.48 src/sys/dev/usb/TODO Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Nick Hudson" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Wed, 7 Aug 2019 07:25:09 +0000 Module Name: src Committed By: skrll Date: Wed Aug 7 07:25:09 UTC 2019 Modified Files: src/sys/dev/usb: files.usb Log Message: usmsc needs usbnet To generate a diff of this commit: cvs rdiff -u -r1.159 -r1.160 src/sys/dev/usb/files.usb Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Nick Hudson" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Wed, 7 Aug 2019 07:25:50 +0000 Module Name: src Committed By: skrll Date: Wed Aug 7 07:25:50 UTC 2019 Modified Files: src/sys/dev/usb: usbnet.h Log Message: Trailing whitespace To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/sys/dev/usb/usbnet.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Wed, 7 Aug 2019 08:16:24 +0000 Module Name: src Committed By: mrg Date: Wed Aug 7 08:16:24 UTC 2019 Modified Files: src/sys/dev/usb: if_smsc.c Log Message: fix module build: s/axen/smsc/ in one place. To generate a diff of this commit: cvs rdiff -u -r1.47 -r1.48 src/sys/dev/usb/if_smsc.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Maya Rashish" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Wed, 7 Aug 2019 10:01:05 +0000 Module Name: src Committed By: maya Date: Wed Aug 7 10:01:05 UTC 2019 Modified Files: src/sys/dev/usb: usbnet.c Log Message: Don't tell userland about ENETRESET even if a usbnet driver didn't define un_ioctl_cb. To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9 src/sys/dev/usb/usbnet.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Nick Hudson" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Wed, 7 Aug 2019 19:21:48 +0000 Module Name: src Committed By: skrll Date: Wed Aug 7 19:21:48 UTC 2019 Modified Files: src/sys/dev/usb: files.usb if_udav.c if_udavreg.h Log Message: Convert udav(4) to usbnet. Based on a diff from mrg@ To generate a diff of this commit: cvs rdiff -u -r1.160 -r1.161 src/sys/dev/usb/files.usb cvs rdiff -u -r1.60 -r1.61 src/sys/dev/usb/if_udav.c cvs rdiff -u -r1.14 -r1.15 src/sys/dev/usb/if_udavreg.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Nick Hudson" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Wed, 7 Aug 2019 20:34:12 +0000 Module Name: src Committed By: skrll Date: Wed Aug 7 20:34:12 UTC 2019 Modified Files: src/sys/dev/usb: if_udav.c Log Message: Compare against 0 for missing endpoint. From mrg@ To generate a diff of this commit: cvs rdiff -u -r1.61 -r1.62 src/sys/dev/usb/if_udav.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Michael Lorenz" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Wed, 7 Aug 2019 22:26:29 +0000 Module Name: src Committed By: macallan Date: Wed Aug 7 22:26:29 UTC 2019 Modified Files: src/sys/dev/usb: if_urndis.c Log Message: match USB_PRODUCT_SAMSUNG_ANDROID too now this works with my Galaxy S8 active To generate a diff of this commit: cvs rdiff -u -r1.22 -r1.23 src/sys/dev/usb/if_urndis.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Maya Rashish" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev Date: Thu, 8 Aug 2019 06:16:40 +0000 Module Name: src Committed By: maya Date: Thu Aug 8 06:16:40 UTC 2019 Modified Files: src/sys/dev/ic: rndisreg.h src/sys/dev/usb: if_urndis.c Log Message: Teach urndis to handle some REMOTE_NDIS_INDICATE_STATUS_MSG. If the status is reasonable, don't tell userland we got an error. Stops spurious EIO. >From openbsd. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/sys/dev/ic/rndisreg.h cvs rdiff -u -r1.23 -r1.24 src/sys/dev/usb/if_urndis.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Thu, 8 Aug 2019 18:03:41 +0000 Module Name: src Committed By: mrg Date: Thu Aug 8 18:03:41 UTC 2019 Modified Files: src/sys/dev/usb: if_urndis.c Log Message: fix arm64 build (new le32toh() call needs sys/endian.h which is probably include by some other header on amd64?) To generate a diff of this commit: cvs rdiff -u -r1.24 -r1.25 src/sys/dev/usb/if_urndis.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys Date: Fri, 9 Aug 2019 01:17:33 +0000 Module Name: src Committed By: mrg Date: Fri Aug 9 01:17:33 UTC 2019 Modified Files: src/sys/dev/usb: if_axe.c if_axen.c if_cdce.c if_smsc.c if_udav.c if_ure.c usbnet.c usbnet.h src/sys/sys: param.h Log Message: update usbnet some: - move rx/tx xfer flags into usbnet_cdata - move the callbacks into usbnet_ops structure - move rx/tx xfer flags arguments from usbnet_init_rx_tx() and move them all into usbnet_attach() arguments - s/miibus/mii/ in some places for consistency other clean up: - create wrapper functions for callbacks, move knowledge about special handling (OK to be missing, error eating) there. - use cdata pointer if already available - provide some more macros (will be real functions later) for accessing usbnet members, use existing ones more bump kernel version. To generate a diff of this commit: cvs rdiff -u -r1.106 -r1.107 src/sys/dev/usb/if_axe.c cvs rdiff -u -r1.56 -r1.57 src/sys/dev/usb/if_axen.c cvs rdiff -u -r1.58 -r1.59 src/sys/dev/usb/if_cdce.c cvs rdiff -u -r1.48 -r1.49 src/sys/dev/usb/if_smsc.c cvs rdiff -u -r1.62 -r1.63 src/sys/dev/usb/if_udav.c cvs rdiff -u -r1.18 -r1.19 src/sys/dev/usb/if_ure.c cvs rdiff -u -r1.9 -r1.10 src/sys/dev/usb/usbnet.c cvs rdiff -u -r1.6 -r1.7 src/sys/dev/usb/usbnet.h cvs rdiff -u -r1.603 -r1.604 src/sys/sys/param.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Fri, 9 Aug 2019 02:14:35 +0000 Module Name: src Committed By: mrg Date: Fri Aug 9 02:14:35 UTC 2019 Modified Files: src/sys/dev/usb: usbnet.h Log Message: ride 9.99.5 bump: add un_flags here. many of the softc's only have a flags member to control device-specific issues, and this means they can use "struct usbnet" as their softc directly. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/dev/usb/usbnet.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Fri, 9 Aug 2019 02:52:59 +0000 Module Name: src Committed By: mrg Date: Fri Aug 9 02:52:59 UTC 2019 Modified Files: src/sys/dev/usb: if_axe.c if_axen.c if_cdce.c if_ure.c Log Message: use new un_flags member of usbnet: - axen(4) and cdce(4) are now able to use struct usbnet directly as softc, udav also done but untested To generate a diff of this commit: cvs rdiff -u -r1.107 -r1.108 src/sys/dev/usb/if_axe.c cvs rdiff -u -r1.57 -r1.58 src/sys/dev/usb/if_axen.c cvs rdiff -u -r1.59 -r1.60 src/sys/dev/usb/if_cdce.c cvs rdiff -u -r1.19 -r1.20 src/sys/dev/usb/if_ure.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Fri, 9 Aug 2019 02:56:51 +0000 Module Name: src Committed By: mrg Date: Fri Aug 9 02:56:51 UTC 2019 Modified Files: src/sys/dev/usb: TODO Log Message: update ethernet driver notes: mark udav as done, and every thing except umb(4) as patch available, with urndis probably working (need to test the latest change before being commited.) still need testers for: aue, cue, kue, mue, upl and url. no umb patch yet. To generate a diff of this commit: cvs rdiff -u -r1.48 -r1.49 src/sys/dev/usb/TODO Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Fri, 9 Aug 2019 06:38:39 +0000 Module Name: src Committed By: mrg Date: Fri Aug 9 06:38:39 UTC 2019 Modified Files: src/sys/dev/usb: TODO files.usb if_urndis.c Log Message: switch urndis(4) to usbnet. thanks to maya@ for testing and helping fix the few issues in the conversion. To generate a diff of this commit: cvs rdiff -u -r1.49 -r1.50 src/sys/dev/usb/TODO cvs rdiff -u -r1.161 -r1.162 src/sys/dev/usb/files.usb cvs rdiff -u -r1.25 -r1.26 src/sys/dev/usb/if_urndis.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Fri, 9 Aug 2019 06:44:42 +0000 Module Name: src Committed By: mrg Date: Fri Aug 9 06:44:42 UTC 2019 Modified Files: src/sys/dev/usb: if_udav.c Log Message: switch to usbnet as softc, using un_flags. To generate a diff of this commit: cvs rdiff -u -r1.63 -r1.64 src/sys/dev/usb/if_udav.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Fri, 9 Aug 2019 06:46:35 +0000 Module Name: src Committed By: mrg Date: Fri Aug 9 06:46:35 UTC 2019 Modified Files: src/sys/dev/usb: if_urevar.h Log Message: missed commit should be paired with if_ure.c 1.20. To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/sys/dev/usb/if_urevar.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Nick Hudson" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Fri, 9 Aug 2019 07:54:06 +0000 Module Name: src Committed By: skrll Date: Fri Aug 9 07:54:06 UTC 2019 Modified Files: src/sys/dev/usb: if_smsc.c Log Message: G/C To generate a diff of this commit: cvs rdiff -u -r1.49 -r1.50 src/sys/dev/usb/if_smsc.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys Date: Sat, 10 Aug 2019 02:17:36 +0000 Module Name: src Committed By: mrg Date: Sat Aug 10 02:17:36 UTC 2019 Modified Files: src/sys/dev/usb: if_axe.c if_axen.c if_cdce.c if_smsc.c if_udav.c if_ure.c if_urndis.c usbnet.c usbnet.h src/sys/sys: param.h Log Message: reduce the scope of struct usbnet: - move a large number of members internal to usbnet.c's new "struct usbnet_private". - provide accessors for a few of these - move struct usbnet_cdata into usbnet.c as well, but move bufsz, list count, and xfer flags back out into struct usbnet, and have them set as part of the setup efore usbnet_attach() - split the intr pipe parts into their own structure - move all the main usbnet*lock* code into usbnet.c too usbnet_attach() goes down to 2 args, and the inputs needed are now the full contents of 'struct usbnet' besides the driver owned 'un_flags' and usbnet owned 'un_pri'. welcome netbsd 9.99.6. To generate a diff of this commit: cvs rdiff -u -r1.108 -r1.109 src/sys/dev/usb/if_axe.c cvs rdiff -u -r1.58 -r1.59 src/sys/dev/usb/if_axen.c cvs rdiff -u -r1.60 -r1.61 src/sys/dev/usb/if_cdce.c cvs rdiff -u -r1.50 -r1.51 src/sys/dev/usb/if_smsc.c cvs rdiff -u -r1.64 -r1.65 src/sys/dev/usb/if_udav.c cvs rdiff -u -r1.20 -r1.21 src/sys/dev/usb/if_ure.c cvs rdiff -u -r1.26 -r1.27 src/sys/dev/usb/if_urndis.c cvs rdiff -u -r1.10 -r1.11 src/sys/dev/usb/usbnet.c cvs rdiff -u -r1.8 -r1.9 src/sys/dev/usb/usbnet.h cvs rdiff -u -r1.604 -r1.605 src/sys/sys/param.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src Date: Sat, 10 Aug 2019 20:35:36 +0000 Module Name: src Committed By: mrg Date: Sat Aug 10 20:35:36 UTC 2019 Modified Files: src/distrib/sets/lists/comp: mi src/share/man/man9: Makefile Added Files: src/share/man/man9: usbnet.9 Log Message: usbnet may be stable now. document it. To generate a diff of this commit: cvs rdiff -u -r1.2278 -r1.2279 src/distrib/sets/lists/comp/mi cvs rdiff -u -r1.437 -r1.438 src/share/man/man9/Makefile cvs rdiff -u -r0 -r1.1 src/share/man/man9/usbnet.9 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sun, 11 Aug 2019 01:04:33 +0000 Module Name: src Committed By: mrg Date: Sun Aug 11 01:04:33 UTC 2019 Modified Files: src/sys/dev/usb: if_axe.c if_axen.c if_cdce.c if_ure.c Log Message: in tx_prepare callback make sure to reject any mbuf that is larger than can fit in the buffer. done at the driver and not usbnet layer because the driver knows how much beyond the mbuf data needs to be sent (headers and trailers.) axen(4) had a KASSERT() for this condition, but there's no invariant here we can check so it's best as an error return. XXX: only tested on these drivers, needs to be copied to udav, smsc and urndis after testing as well as the not commited conversions. To generate a diff of this commit: cvs rdiff -u -r1.109 -r1.110 src/sys/dev/usb/if_axe.c cvs rdiff -u -r1.59 -r1.60 src/sys/dev/usb/if_axen.c cvs rdiff -u -r1.61 -r1.62 src/sys/dev/usb/if_cdce.c cvs rdiff -u -r1.21 -r1.22 src/sys/dev/usb/if_ure.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sun, 11 Aug 2019 01:29:45 +0000 Module Name: src Committed By: mrg Date: Sun Aug 11 01:29:45 UTC 2019 Modified Files: src/sys/dev/usb: usbnet.h Log Message: adjust some comments to reality. To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10 src/sys/dev/usb/usbnet.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sun, 11 Aug 2019 01:31:19 +0000 Module Name: src Committed By: mrg Date: Sun Aug 11 01:31:19 UTC 2019 Modified Files: src/sys/dev/usb: usbnet.c Log Message: - use usbnet_isowned*() more - more const To generate a diff of this commit: cvs rdiff -u -r1.11 -r1.12 src/sys/dev/usb/usbnet.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sun, 11 Aug 2019 02:37:04 +0000 Module Name: src Committed By: mrg Date: Sun Aug 11 02:37:04 UTC 2019 Modified Files: src/sys/dev/usb: if_axe.c if_axen.c if_cdce.c if_ure.c Log Message: copy a pattern from if_udav.c, which already had "too much" check. even though overflow or underflow is really unlikely here, reorder various expressions to reduce the likelyhood even further. To generate a diff of this commit: cvs rdiff -u -r1.110 -r1.111 src/sys/dev/usb/if_axe.c cvs rdiff -u -r1.60 -r1.61 src/sys/dev/usb/if_axen.c cvs rdiff -u -r1.62 -r1.63 src/sys/dev/usb/if_cdce.c cvs rdiff -u -r1.22 -r1.23 src/sys/dev/usb/if_ure.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sun, 11 Aug 2019 05:14:42 +0000 Module Name: src Committed By: mrg Date: Sun Aug 11 05:14:42 UTC 2019 Modified Files: src/sys/dev/usb: if_axe.c Log Message: void -Wsign-compare issue and add a stupid cast. revert this if m_pkthdr.len becomes unsigned. To generate a diff of this commit: cvs rdiff -u -r1.111 -r1.112 src/sys/dev/usb/if_axe.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Nick Hudson" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sun, 11 Aug 2019 06:54:15 +0000 Module Name: src Committed By: skrll Date: Sun Aug 11 06:54:15 UTC 2019 Modified Files: src/sys/dev/usb: if_smsc.c Log Message: Add a check in smsc_tx_prepare for the mbuf being too big. Discussed with mrg@ To generate a diff of this commit: cvs rdiff -u -r1.51 -r1.52 src/sys/dev/usb/if_smsc.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Nick Hudson" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sun, 11 Aug 2019 07:12:08 +0000 Module Name: src Committed By: skrll Date: Sun Aug 11 07:12:08 UTC 2019 Modified Files: src/sys/dev/usb: TODO Log Message: G/C To generate a diff of this commit: cvs rdiff -u -r1.50 -r1.51 src/sys/dev/usb/TODO Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Nick Hudson" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sun, 11 Aug 2019 07:58:16 +0000 Module Name: src Committed By: skrll Date: Sun Aug 11 07:58:16 UTC 2019 Modified Files: src/sys/dev/usb: if_smsc.c Log Message: Correct the length of the buffer to copy into the mbuf. Spotted by sc dying. To generate a diff of this commit: cvs rdiff -u -r1.52 -r1.53 src/sys/dev/usb/if_smsc.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Thomas Klausner" To: source-changes@NetBSD.org Subject: CVS commit: src/share/man/man9 Date: Sun, 11 Aug 2019 08:26:46 +0000 Module Name: src Committed By: wiz Date: Sun Aug 11 08:26:46 UTC 2019 Modified Files: src/share/man/man9: usbnet.9 Log Message: Various fixes: Pp cleanup, use more macros, sort sections, fix typos, Americanize spelling (like other man pages), fix macro arguments. To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2 src/share/man/man9/usbnet.9 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Nick Hudson" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sun, 11 Aug 2019 08:56:54 +0000 Module Name: src Committed By: skrll Date: Sun Aug 11 08:56:53 UTC 2019 Modified Files: src/sys/dev/usb: if_udav.c Log Message: Appease module build To generate a diff of this commit: cvs rdiff -u -r1.65 -r1.66 src/sys/dev/usb/if_udav.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Nick Hudson" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sun, 11 Aug 2019 08:57:36 +0000 Module Name: src Committed By: skrll Date: Sun Aug 11 08:57:36 UTC 2019 Modified Files: src/sys/dev/usb: if_axen.c if_ure.c Log Message: Appease module build To generate a diff of this commit: cvs rdiff -u -r1.61 -r1.62 src/sys/dev/usb/if_axen.c cvs rdiff -u -r1.23 -r1.24 src/sys/dev/usb/if_ure.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Nick Hudson" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sun, 11 Aug 2019 11:17:36 +0000 Module Name: src Committed By: skrll Date: Sun Aug 11 11:17:36 UTC 2019 Modified Files: src/sys/dev/usb: files.usb if_smsc.c Log Message: Convert smsc_dbg_printf to usbhist To generate a diff of this commit: cvs rdiff -u -r1.162 -r1.163 src/sys/dev/usb/files.usb cvs rdiff -u -r1.53 -r1.54 src/sys/dev/usb/if_smsc.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Nick Hudson" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sun, 11 Aug 2019 12:16:59 +0000 Module Name: src Committed By: skrll Date: Sun Aug 11 12:16:59 UTC 2019 Modified Files: src/sys/dev/usb: if_smsc.c Log Message: Fix and improve USMSC_DEBUG To generate a diff of this commit: cvs rdiff -u -r1.54 -r1.55 src/sys/dev/usb/if_smsc.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Juergen Hannken-Illjes" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sun, 11 Aug 2019 13:16:10 +0000 Replied: Mon, 12 Aug 2019 07:04:18 +1000 Replied: hannken@NetBSD.org Module Name: src Committed By: hannken Date: Sun Aug 11 13:16:10 UTC 2019 Modified Files: src/sys/dev/usb: if_urndis.c Log Message: urndis_attach: change "sc->sc_bulkout_no" to "un->un_ed[USBNET_ENDPT_TX]" in DPRINTF(). Kernels ALL/amd64 and ALL/i386 compile again. To generate a diff of this commit: cvs rdiff -u -r1.27 -r1.28 src/sys/dev/usb/if_urndis.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/share/man/man9 Date: Sun, 11 Aug 2019 21:33:09 +0000 Module Name: src Committed By: mrg Date: Sun Aug 11 21:33:09 UTC 2019 Modified Files: src/share/man/man9: usbnet.9 Log Message: minor rewording of a few places and add a new section to describe the type of changes required to port a driver to usbnet interfaces. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/share/man/man9/usbnet.9 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sun, 11 Aug 2019 22:55:03 +0000 Module Name: src Committed By: mrg Date: Sun Aug 11 22:55:03 UTC 2019 Modified Files: src/sys/dev/usb: ohci.c Log Message: relax an assert to be mutex_owned || polling. half of the patch i sent for netbsd-8 in PR#54331. the other half is already applied. To generate a diff of this commit: cvs rdiff -u -r1.289 -r1.290 src/sys/dev/usb/ohci.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sun, 11 Aug 2019 23:55:43 +0000 Module Name: src Committed By: mrg Date: Sun Aug 11 23:55:43 UTC 2019 Modified Files: src/sys/dev/usb: if_axe.c if_smsc.c if_ure.c if_urndis.c usbnet.c Log Message: don't set dv_private. it's a bad pattern and only didn't trip kmem_free() lossage because struct usbnet is at the start of the softc. for now, enforce this as part of the ABI. catch up urndis with tx_prepare checking buffer length, and also add an assert to usbnet_start_locked() to match. To generate a diff of this commit: cvs rdiff -u -r1.112 -r1.113 src/sys/dev/usb/if_axe.c cvs rdiff -u -r1.55 -r1.56 src/sys/dev/usb/if_smsc.c cvs rdiff -u -r1.24 -r1.25 src/sys/dev/usb/if_ure.c cvs rdiff -u -r1.28 -r1.29 src/sys/dev/usb/if_urndis.c cvs rdiff -u -r1.12 -r1.13 src/sys/dev/usb/usbnet.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/share/man/man9 Date: Mon, 12 Aug 2019 00:01:23 +0000 Module Name: src Committed By: mrg Date: Mon Aug 12 00:01:23 UTC 2019 Modified Files: src/share/man/man9: usbnet.9 Log Message: remove mention of dv_private and note that usbnet must be first. fix Ethernet capitalisation in one place. To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/share/man/man9/usbnet.9 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Nick Hudson" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Mon, 12 Aug 2019 08:40:09 +0000 Module Name: src Committed By: skrll Date: Mon Aug 12 08:40:09 UTC 2019 Modified Files: src/sys/dev/usb: if_smscreg.h Log Message: Fix an unused register field define To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/sys/dev/usb/if_smscreg.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Nick Hudson" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Mon, 12 Aug 2019 08:52:39 +0000 Module Name: src Committed By: skrll Date: Mon Aug 12 08:52:39 UTC 2019 Modified Files: src/sys/dev/usb: if_cdce.c Log Message: Trailing whitespace To generate a diff of this commit: cvs rdiff -u -r1.63 -r1.64 src/sys/dev/usb/if_cdce.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys Date: Wed, 14 Aug 2019 03:44:59 +0000 Module Name: src Committed By: mrg Date: Wed Aug 14 03:44:58 UTC 2019 Modified Files: src/sys/dev/usb: if_axe.c if_axen.c if_cdce.c if_smsc.c if_udav.c if_ure.c if_urndis.c usbnet.c usbnet.h src/sys/sys: param.h Log Message: introduce usbnet_set_dying(). will be used by url(4) conversion. bump version. introduce USBNET_MODULE() that encompasses almost all the module specific code for usbnet modules. they still need to include the relevant ioconf.c, but everything else is now just, eg, USBNET_MODULE(axen) To generate a diff of this commit: cvs rdiff -u -r1.113 -r1.114 src/sys/dev/usb/if_axe.c cvs rdiff -u -r1.62 -r1.63 src/sys/dev/usb/if_axen.c cvs rdiff -u -r1.64 -r1.65 src/sys/dev/usb/if_cdce.c cvs rdiff -u -r1.56 -r1.57 src/sys/dev/usb/if_smsc.c cvs rdiff -u -r1.66 -r1.67 src/sys/dev/usb/if_udav.c cvs rdiff -u -r1.25 -r1.26 src/sys/dev/usb/if_ure.c cvs rdiff -u -r1.29 -r1.30 src/sys/dev/usb/if_urndis.c cvs rdiff -u -r1.13 -r1.14 src/sys/dev/usb/usbnet.c cvs rdiff -u -r1.10 -r1.11 src/sys/dev/usb/usbnet.h cvs rdiff -u -r1.606 -r1.607 src/sys/sys/param.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys Date: Thu, 15 Aug 2019 05:52:23 +0000 Module Name: src Committed By: mrg Date: Thu Aug 15 05:52:23 UTC 2019 Modified Files: src/sys/dev/usb: if_axe.c if_axen.c if_cdce.c if_smsc.c if_udav.c if_ure.c if_urndis.c usbnet.c usbnet.h src/sys/sys: param.h Log Message: - usbnet_rx_loop_cb's usbd_xfer parameter is never used and available in the usbnet_chain if needed. remove it - usbnet media status change already set link to false, don't repeat this in every driver - don't clear link in stop, nothing was re-enabling it for non-MII - add optional uno_tick_cb(struct usbnet *un) that is called from the usbnet tick timer - remove wrong debug sysctl prototype rx_loop and timer are kernel versions changes, but hopefully this is the last one for usbnet. working with 3 more drivers now (cue, mue and url), leaving only aue, kue, upl and umb undone (aue may work with previously supported devices, mine doesn't work with our driver, kue and upl have patches for testing and umb is undone.) To generate a diff of this commit: cvs rdiff -u -r1.114 -r1.115 src/sys/dev/usb/if_axe.c cvs rdiff -u -r1.63 -r1.64 src/sys/dev/usb/if_axen.c cvs rdiff -u -r1.65 -r1.66 src/sys/dev/usb/if_cdce.c cvs rdiff -u -r1.57 -r1.58 src/sys/dev/usb/if_smsc.c cvs rdiff -u -r1.67 -r1.68 src/sys/dev/usb/if_udav.c cvs rdiff -u -r1.26 -r1.27 src/sys/dev/usb/if_ure.c cvs rdiff -u -r1.30 -r1.31 src/sys/dev/usb/if_urndis.c cvs rdiff -u -r1.14 -r1.15 src/sys/dev/usb/usbnet.c cvs rdiff -u -r1.11 -r1.12 src/sys/dev/usb/usbnet.h cvs rdiff -u -r1.607 -r1.608 src/sys/sys/param.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Thu, 15 Aug 2019 08:02:32 +0000 Module Name: src Committed By: mrg Date: Thu Aug 15 08:02:32 UTC 2019 Modified Files: src/sys/dev/usb: files.usb if_cue.c if_cuereg.h if_mue.c if_muereg.h if_muevar.h if_url.c if_urlreg.h Log Message: port cue(4), mue(4) and url(4) to usbnet(9). diffstat says: 8 files changed, 911 insertions(+), 3087 deletions(-) To generate a diff of this commit: cvs rdiff -u -r1.163 -r1.164 src/sys/dev/usb/files.usb cvs rdiff -u -r1.84 -r1.85 src/sys/dev/usb/if_cue.c cvs rdiff -u -r1.22 -r1.23 src/sys/dev/usb/if_cuereg.h cvs rdiff -u -r1.51 -r1.52 src/sys/dev/usb/if_mue.c cvs rdiff -u -r1.5 -r1.6 src/sys/dev/usb/if_muereg.h cvs rdiff -u -r1.8 -r1.9 src/sys/dev/usb/if_muevar.h cvs rdiff -u -r1.67 -r1.68 src/sys/dev/usb/if_url.c cvs rdiff -u -r1.13 -r1.14 src/sys/dev/usb/if_urlreg.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/share/man/man9 Date: Thu, 15 Aug 2019 08:33:14 +0000 Module Name: src Committed By: mrg Date: Thu Aug 15 08:33:14 UTC 2019 Modified Files: src/share/man/man9: usbnet.9 Log Message: - document locking requirements more - expand uno_foo() docs to include return type and parameters - expand uno_intr() docs - add uno_tick() - fix various typoes To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/share/man/man9/usbnet.9 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "Thomas Klausner" To: source-changes@NetBSD.org Subject: CVS commit: src/share/man/man9 Date: Thu, 15 Aug 2019 08:37:13 +0000 Module Name: src Committed By: wiz Date: Thu Aug 15 08:37:13 UTC 2019 Modified Files: src/share/man/man9: usbnet.9 Log Message: Fix Xr usage. To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/share/man/man9/usbnet.9 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/doc Date: Thu, 15 Aug 2019 08:55:06 +0000 Module Name: src Committed By: mrg Date: Thu Aug 15 08:55:06 UTC 2019 Modified Files: src/doc: CHANGES Log Message: usbnet(9): Add common framework for USB network devices. Port the axe(4), axen(4), cdce(4), cue(4), mue(4), smsc(4), udav(4), ure(4), url(4), and urndis(4) drivers fixing many bugs and porting to NET_MPSAFE in the process. [mrg 20190814] To generate a diff of this commit: cvs rdiff -u -r1.2567 -r1.2568 src/doc/CHANGES Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Fri, 16 Aug 2019 08:29:20 +0000 Module Name: src Committed By: mrg Date: Fri Aug 16 08:29:20 UTC 2019 Modified Files: src/sys/dev/usb: if_axe.c if_udav.c if_ure.c Log Message: make the default debug level zero. To generate a diff of this commit: cvs rdiff -u -r1.115 -r1.116 src/sys/dev/usb/if_axe.c cvs rdiff -u -r1.68 -r1.69 src/sys/dev/usb/if_udav.c cvs rdiff -u -r1.27 -r1.28 src/sys/dev/usb/if_ure.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Fri, 16 Aug 2019 08:38:21 +0000 Module Name: src Committed By: mrg Date: Fri Aug 16 08:38:21 UTC 2019 Modified Files: src/sys/dev/usb: usbnet.c Log Message: internal to usbnet: add buflen param to usbnet_newbuf(). use this to skip allocating an mbuf cluster for small packets (ported from kue(4).) remove usbnet_rx_start_pipes()'s always usbnet_rxeof argument. To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16 src/sys/dev/usb/usbnet.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Fri, 16 Aug 2019 08:51:10 +0000 Module Name: src Committed By: mrg Date: Fri Aug 16 08:51:10 UTC 2019 Modified Files: src/sys/dev/usb: if_kue.c if_kuereg.h Log Message: port kue(4) to usbnet(9). interesting notes: - move KUE_RXFILT_PROMISC setting into kue_setiff() from kue_init() to avoid multiple setting KUE_CMD_SET_PKT_FILTER reg multiple times - software-only constructs moved from if_kuereg.h into if_kue.c - kue is the first (umb(4) will need it to, i think) to have its own autoconf detach routine remain - un_tx_xfer_flags is 0 here, not USBD_FORCE_SHORT_XFER - fix a potential data exposure (but probably not without a USB protocol tap). kue needs the transfers to be 64-byte aligned, and while i doubt it sends more than the frame provided, were sending random kernel data (whatever was the 0-63 bytes to alignment) to the device. diffstat says: 2 files changed, 189 insertions(+), 739 deletions(-) To generate a diff of this commit: cvs rdiff -u -r1.97 -r1.98 src/sys/dev/usb/if_kue.c cvs rdiff -u -r1.23 -r1.24 src/sys/dev/usb/if_kuereg.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Fri, 16 Aug 2019 08:52:46 +0000 Module Name: src Committed By: mrg Date: Fri Aug 16 08:52:46 UTC 2019 Modified Files: src/sys/dev/usb: files.usb Log Message: kue now depends upon usbnet. To generate a diff of this commit: cvs rdiff -u -r1.164 -r1.165 src/sys/dev/usb/files.usb Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sun, 18 Aug 2019 08:16:34 +0000 Module Name: src Committed By: mrg Date: Sun Aug 18 08:16:34 UTC 2019 Modified Files: src/sys/dev/usb: if_urndis.c Log Message: usbnet_ifp() doesn't work before usbnet_attach(). avoid it. To generate a diff of this commit: cvs rdiff -u -r1.31 -r1.32 src/sys/dev/usb/if_urndis.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sun, 18 Aug 2019 09:29:38 +0000 Module Name: src Committed By: mrg Date: Sun Aug 18 09:29:38 UTC 2019 Modified Files: src/sys/dev/usb: files.usb if_upl.c usbnet.c Log Message: update usbnet slight: - drivers that want to use if_input() will also set _if_input. for now, avoid attaching a per-cpu queue for them. use if_initialize() and if_register(). - when stopping pipes, don't give up after the first failure, but keep the first failure error for return and keep going - if 0 a KASSERT() in usbnet_init_rx_tx(). there's a path via if_mcast_op() that can have the ifnet unlocked today.. - in usbnet_watchdog(), abort the pipe instead of faking tx completion. avoids issues with devices with more than one tx descriptor, as well as avoiding triggering usb asserts. with these, upl(4) port to usbnet(9) now works. (would be a version bump, but upl(4) and the unported umb(4) are the only consumers that would care.) To generate a diff of this commit: cvs rdiff -u -r1.165 -r1.166 src/sys/dev/usb/files.usb cvs rdiff -u -r1.64 -r1.65 src/sys/dev/usb/if_upl.c cvs rdiff -u -r1.16 -r1.17 src/sys/dev/usb/usbnet.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/doc Date: Sun, 18 Aug 2019 09:43:26 +0000 Module Name: src Committed By: mrg Date: Sun Aug 18 09:43:26 UTC 2019 Modified Files: src/doc: CHANGES Log Message: note kue/upl ported to usbnet. To generate a diff of this commit: cvs rdiff -u -r1.2569 -r1.2570 src/doc/CHANGES Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sun, 18 Aug 2019 09:46:58 +0000 Module Name: src Committed By: mrg Date: Sun Aug 18 09:46:58 UTC 2019 Modified Files: src/sys/dev/usb: usbnet.c Log Message: fix a think-o in the previous: don't return when saving the first error. from skrll@. To generate a diff of this commit: cvs rdiff -u -r1.17 -r1.18 src/sys/dev/usb/usbnet.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Mon, 19 Aug 2019 06:35:15 +0000 Module Name: src Committed By: mrg Date: Mon Aug 19 06:35:14 UTC 2019 Modified Files: src/sys/dev/usb: usbhist.h usbnet.c Log Message: add USBHIST_CALLARGS() frontend to KERNHIST_CALLARGS(). add USBNETHIST_CALLARGS() frontend to USBHIST_CALLARGS(). use both in read/write reg, instead of aprint. use %jx and (uintptr_t) and fix the 32 bit debug build. To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/sys/dev/usb/usbhist.h cvs rdiff -u -r1.18 -r1.19 src/sys/dev/usb/usbnet.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Mon, 19 Aug 2019 07:20:07 +0000 Module Name: src Committed By: mrg Date: Mon Aug 19 07:20:07 UTC 2019 Modified Files: src/sys/dev/usb: if_urtwn.c Log Message: move the call to rnd_attach_source() earlier and add a matching call to rnd_detach_source() into detach. fixes an attach-detach-reattach issue where the rnd source was already known. To generate a diff of this commit: cvs rdiff -u -r1.71 -r1.72 src/sys/dev/usb/if_urtwn.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Mon, 19 Aug 2019 07:33:38 +0000 Module Name: src Committed By: mrg Date: Mon Aug 19 07:33:37 UTC 2019 Modified Files: src/sys/dev/usb: if_axe.c if_axen.c if_mue.c if_smsc.c if_ure.c usbnet.c Log Message: move the check against un_phyno from usbnet back into the drivers that do this (axe, axen, mue, smsc, ure.) it made mii scanning only work for phy 0, and aue needs it for at least one device. fix smsc to return usbd_status not -1 on failure. XXX smsc was writing to '*val' even in error cases, it does not now. remove a double call to IFQ_SET_READY() (noticed by chuq). avoid unlock+instant relock by using usbnet_lock_mii_un_locked(). To generate a diff of this commit: cvs rdiff -u -r1.116 -r1.117 src/sys/dev/usb/if_axe.c cvs rdiff -u -r1.64 -r1.65 src/sys/dev/usb/if_axen.c cvs rdiff -u -r1.52 -r1.53 src/sys/dev/usb/if_mue.c cvs rdiff -u -r1.58 -r1.59 src/sys/dev/usb/if_smsc.c cvs rdiff -u -r1.28 -r1.29 src/sys/dev/usb/if_ure.c cvs rdiff -u -r1.19 -r1.20 src/sys/dev/usb/usbnet.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Mon, 19 Aug 2019 08:07:55 +0000 Module Name: src Committed By: mrg Date: Mon Aug 19 08:07:55 UTC 2019 Modified Files: src/sys/dev/usb: TODO.usbmp Log Message: axe, udav, url, cue, kue, smsc, udav[*], upl, url and urdnis are now all ported to usbmp and mpsafe interfaces, and have all been tested too. [*] udav has an issue with usbnet port for some devices. To generate a diff of this commit: cvs rdiff -u -r1.14 -r1.15 src/sys/dev/usb/TODO.usbmp Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Tue, 20 Aug 2019 06:18:54 +0000 Module Name: src Committed By: mrg Date: Tue Aug 20 06:18:54 UTC 2019 Modified Files: src/sys/dev/usb: usbnet.c Log Message: properly fix the kernhist calls. one must cast and cast and cast and maybe a fish will be caught... To generate a diff of this commit: cvs rdiff -u -r1.20 -r1.21 src/sys/dev/usb/usbnet.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys Date: Tue, 20 Aug 2019 06:37:07 +0000 Module Name: src Committed By: mrg Date: Tue Aug 20 06:37:06 UTC 2019 Modified Files: src/sys/dev/usb: if_axe.c if_axen.c if_cdce.c if_cue.c if_kue.c if_mue.c if_smsc.c if_udav.c if_upl.c if_ure.c if_url.c if_urndis.c usbnet.c usbnet.h src/sys/sys: param.h Log Message: couple more changes to usbnet(9): - MII read/write reg return int instead of usbd_status (requested by skrll) - usbnet_attach_ifp(9) changes arg, two mii-specific flags are placed by a pointer to new struct usbnet_mii. if not NULL, then attach an MII to this interface like previous have_mii parameter. use this to allow ure(4) to properly pass PHY location to mii_attach(). welcome netbsd 9.99.10. To generate a diff of this commit: cvs rdiff -u -r1.117 -r1.118 src/sys/dev/usb/if_axe.c cvs rdiff -u -r1.65 -r1.66 src/sys/dev/usb/if_axen.c src/sys/dev/usb/if_upl.c cvs rdiff -u -r1.66 -r1.67 src/sys/dev/usb/if_cdce.c cvs rdiff -u -r1.85 -r1.86 src/sys/dev/usb/if_cue.c cvs rdiff -u -r1.99 -r1.100 src/sys/dev/usb/if_kue.c cvs rdiff -u -r1.53 -r1.54 src/sys/dev/usb/if_mue.c cvs rdiff -u -r1.59 -r1.60 src/sys/dev/usb/if_smsc.c cvs rdiff -u -r1.69 -r1.70 src/sys/dev/usb/if_udav.c cvs rdiff -u -r1.29 -r1.30 src/sys/dev/usb/if_ure.c cvs rdiff -u -r1.68 -r1.69 src/sys/dev/usb/if_url.c cvs rdiff -u -r1.32 -r1.33 src/sys/dev/usb/if_urndis.c cvs rdiff -u -r1.21 -r1.22 src/sys/dev/usb/usbnet.c cvs rdiff -u -r1.12 -r1.13 src/sys/dev/usb/usbnet.h cvs rdiff -u -r1.608 -r1.609 src/sys/sys/param.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Wed, 21 Aug 2019 06:19:43 +0000 Module Name: src Committed By: mrg Date: Wed Aug 21 06:19:43 UTC 2019 Modified Files: src/sys/dev/usb: xhci.c Log Message: match xhci version 3.10. allows properly finding all the USB busses on new ryzen 3 based systems. unfortunately, the USB busses are still non-functional. To generate a diff of this commit: cvs rdiff -u -r1.108 -r1.109 src/sys/dev/usb/xhci.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Wed, 21 Aug 2019 10:48:38 +0000 Module Name: src Committed By: mrg Date: Wed Aug 21 10:48:37 UTC 2019 Modified Files: src/sys/dev/usb: uhub.c usb.c usb_mem.c usb_subr.c usbdi.c usbdi_util.c usbroothub.c Log Message: convert pairs of USBHIST_CALLED()+USBHIST_LOG*() into USBHIST_CALLARGS() calls. this reduces the number of kernel history lines consumed by these callers, and for the +LOGN versions, add useful log info to a message that just says "called!". reduces the line spam which means the total info in a full log is significantly increased. To generate a diff of this commit: cvs rdiff -u -r1.142 -r1.143 src/sys/dev/usb/uhub.c cvs rdiff -u -r1.179 -r1.180 src/sys/dev/usb/usb.c cvs rdiff -u -r1.70 -r1.71 src/sys/dev/usb/usb_mem.c cvs rdiff -u -r1.237 -r1.238 src/sys/dev/usb/usb_subr.c cvs rdiff -u -r1.182 -r1.183 src/sys/dev/usb/usbdi.c cvs rdiff -u -r1.74 -r1.75 src/sys/dev/usb/usbdi_util.c cvs rdiff -u -r1.8 -r1.9 src/sys/dev/usb/usbroothub.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Thu, 22 Aug 2019 00:24:07 +0000 Module Name: src Committed By: mrg Date: Thu Aug 22 00:24:07 UTC 2019 Modified Files: src/sys/dev/usb: if_aue.c usbhist.h Log Message: usbhist(9): - add a USBHIST_CALLARGSN() that only prints the message if debug level is N aue(4): - switch from printf() to usbhist for debugging To generate a diff of this commit: cvs rdiff -u -r1.156 -r1.157 src/sys/dev/usb/if_aue.c cvs rdiff -u -r1.5 -r1.6 src/sys/dev/usb/usbhist.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Thu, 22 Aug 2019 00:25:18 +0000 Module Name: src Committed By: mrg Date: Thu Aug 22 00:25:18 UTC 2019 Modified Files: src/sys/dev/usb: if_aue.c Log Message: like most things: turn debug off by default, sysctl to enable To generate a diff of this commit: cvs rdiff -u -r1.157 -r1.158 src/sys/dev/usb/if_aue.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Thu, 22 Aug 2019 07:38:06 +0000 Module Name: src Committed By: mrg Date: Thu Aug 22 07:38:06 UTC 2019 Modified Files: src/sys/dev/usb: if_aue.c usbdi.c Log Message: fix more kernhist vs 32 bit issues. To generate a diff of this commit: cvs rdiff -u -r1.158 -r1.159 src/sys/dev/usb/if_aue.c cvs rdiff -u -r1.183 -r1.184 src/sys/dev/usb/usbdi.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Thu, 22 Aug 2019 09:16:09 +0000 Module Name: src Committed By: mrg Date: Thu Aug 22 09:16:08 UTC 2019 Modified Files: src/sys/dev/usb: if_aue.c if_auereg.h Log Message: - move software parts into if_aue.c. - s/Static/static/. To generate a diff of this commit: cvs rdiff -u -r1.159 -r1.160 src/sys/dev/usb/if_aue.c cvs rdiff -u -r1.30 -r1.31 src/sys/dev/usb/if_auereg.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Fri, 23 Aug 2019 04:29:29 +0000 Module Name: src Committed By: mrg Date: Fri Aug 23 04:29:28 UTC 2019 Modified Files: src/sys/dev/usb: usbnet.c Log Message: - remove unused uncd_rx_cnt - add USBNETHIST_CALLARGSN and use it in many places - add more history logs - add a log if watchdog abort leaves uncd_tx_cnt non zero - add a unique (32-bit) number for a each usbnet device and use it for logging - explicitly check for full tx ring in usbnet_start_locked() and return early, which avoids setting the 5 second timer and triggering a watchdog - reset uncd_tx_prod and uncd_tx_cnt to zero in stop To generate a diff of this commit: cvs rdiff -u -r1.22 -r1.23 src/sys/dev/usb/usbnet.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Fri, 23 Aug 2019 04:32:57 +0000 Replied: Fri, 23 Aug 2019 14:48:08 +1000 Replied: source-changes-d@NetBSD.org Module Name: src Committed By: mrg Date: Fri Aug 23 04:32:57 UTC 2019 Modified Files: src/sys/dev/usb: if_axe.c if_axen.c if_mue.c if_smsc.c if_udav.c if_ure.c if_url.c usbnet.h Log Message: s/UBSNET_MII_DECL_DEFAULT/USBNET_MII_DECL_DEFAULT/. from sc.dying. To generate a diff of this commit: cvs rdiff -u -r1.118 -r1.119 src/sys/dev/usb/if_axe.c cvs rdiff -u -r1.66 -r1.67 src/sys/dev/usb/if_axen.c cvs rdiff -u -r1.54 -r1.55 src/sys/dev/usb/if_mue.c cvs rdiff -u -r1.60 -r1.61 src/sys/dev/usb/if_smsc.c cvs rdiff -u -r1.70 -r1.71 src/sys/dev/usb/if_udav.c cvs rdiff -u -r1.30 -r1.31 src/sys/dev/usb/if_ure.c cvs rdiff -u -r1.69 -r1.70 src/sys/dev/usb/if_url.c cvs rdiff -u -r1.13 -r1.14 src/sys/dev/usb/usbnet.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Fri, 23 Aug 2019 04:34:51 +0000 Module Name: src Committed By: mrg Date: Fri Aug 23 04:34:51 UTC 2019 Modified Files: src/sys/dev/usb: if_aue.c if_auereg.h Log Message: convert aue(4) to usbnet(9). besides the not-enabled umb(4), this completes the conversion of all the non-wifi usb network devices. To generate a diff of this commit: cvs rdiff -u -r1.160 -r1.161 src/sys/dev/usb/if_aue.c cvs rdiff -u -r1.31 -r1.32 src/sys/dev/usb/if_auereg.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Fri, 23 Aug 2019 04:34:01 +0000 Module Name: src Committed By: mrg Date: Fri Aug 23 04:34:01 UTC 2019 Modified Files: src/sys/dev/usb: xhci.c Log Message: convert a debug message to an error message. will help more quickly identify next time xhci version changes. To generate a diff of this commit: cvs rdiff -u -r1.109 -r1.110 src/sys/dev/usb/xhci.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/share/man/man9 Date: Fri, 23 Aug 2019 05:37:05 +0000 Module Name: src Committed By: mrg Date: Fri Aug 23 05:37:05 UTC 2019 Modified Files: src/share/man/man9: usbnet.9 Log Message: update for usbnet_mii and read/write reg return change. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/share/man/man9/usbnet.9 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Fri, 23 Aug 2019 07:17:31 +0000 Module Name: src Committed By: mrg Date: Fri Aug 23 07:17:31 UTC 2019 Modified Files: src/sys/dev/usb: usb.h Log Message: avoid using old bsd types (u_int etc) so that this compiles with _POSIX_C_SOURCE as noted in PR#48339. To generate a diff of this commit: cvs rdiff -u -r1.117 -r1.118 src/sys/dev/usb/usb.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Fri, 23 Aug 2019 07:29:29 +0000 Module Name: src Committed By: mrg Date: Fri Aug 23 07:29:29 UTC 2019 Modified Files: src/sys/dev/usb: TODO.usbmp Log Message: update the list of splusb drivers (it's grown unfortunately) and explicitly state that they should be converted. To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16 src/sys/dev/usb/TODO.usbmp Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Fri, 23 Aug 2019 07:13:03 +0000 Module Name: src Committed By: mrg Date: Fri Aug 23 07:13:03 UTC 2019 Modified Files: src/sys/dev/usb: TODO Log Message: - remove items that are fixed (usually in the distant past) - usbnet is (almost) done for non wifi - non trivial usbdi documentation exists now To generate a diff of this commit: cvs rdiff -u -r1.51 -r1.52 src/sys/dev/usb/TODO Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Fri, 23 Aug 2019 08:45:25 +0000 Module Name: src Committed By: mrg Date: Fri Aug 23 08:45:25 UTC 2019 Modified Files: src/sys/dev/usb: files.usb Log Message: aue depends upon usbnet To generate a diff of this commit: cvs rdiff -u -r1.166 -r1.167 src/sys/dev/usb/files.usb Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Sat, 24 Aug 2019 07:43:00 +0000 Module Name: src Committed By: mrg Date: Sat Aug 24 07:43:00 UTC 2019 Modified Files: src/sys/dev/usb: usbdi.c Log Message: don't try to deref a maybe-NULL pointer. instead of logging potentially garbage (if not NULL), log the request length. To generate a diff of this commit: cvs rdiff -u -r1.184 -r1.185 src/sys/dev/usb/usbdi.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Wed, 28 Aug 2019 01:44:39 +0000 Module Name: src Committed By: mrg Date: Wed Aug 28 01:44:39 UTC 2019 Modified Files: src/sys/dev/usb: usb_subr.c usbdi.c usbdi.h Log Message: add new usbd_do_request_len() that can allocate a larger than request size buffer. reimplement usbd_do_request_flags() in terms of this. use this for fetching string descriptors. fixes a very strange problem where an axe(4) attaching (either has ugen(4) or axe(4)) would ask for 2 bytes, usb_mem.c would allocate a 2 byte fragment, perform the operation, and sometime shortly afterwards (usually by the time the next allocation is made for this fragment), would become corrupted (usually two bytes were written with 0x0304.) (initial request of 4 bytes also avoids the problem on this device. it really seems like a HC problem -- host should not allow the device to write more than req.wLength! nor should it allow this write to happen after completion.) avoid an (almost) always double-log in usbd_transfer(). To generate a diff of this commit: cvs rdiff -u -r1.238 -r1.239 src/sys/dev/usb/usb_subr.c cvs rdiff -u -r1.185 -r1.186 src/sys/dev/usb/usbdi.c cvs rdiff -u -r1.96 -r1.97 src/sys/dev/usb/usbdi.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. From: "matthew green" To: source-changes@NetBSD.org Subject: CVS commit: src/sys/dev/usb Date: Wed, 28 Aug 2019 06:07:21 +0000 Module Name: src Committed By: mrg Date: Wed Aug 28 06:07:21 UTC 2019 Modified Files: src/sys/dev/usb: usbnet.c Log Message: in usbnet_detach(), check both that the private pointer has been allocated and that unp_attached is true before trying to access anything else. fixes a detach problem noticed by maxv when, eg, the call to usbd_set_config_no() fails and attach bails early. To generate a diff of this commit: cvs rdiff -u -r1.23 -r1.24 src/sys/dev/usb/usbnet.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.