sys/dev/nand/nand_bbt.c
- nand_bbt_block_mark() has a left-shift of negative value issue.

sys/dev/pci/if_et.c
- avoid casts and checking the wrong ethernet address bits

sys/dev/sun/kbd.c
- kbd_input_wskbd() has a missing {} issue.

sys/external/bsd/ipf/netinet/ip_fil_compat.c
- frentry_4_1_0_to_current() has a missing {} issue that really is
  a double code issue.


Index: sys/dev/nand/nand_bbt.c
===================================================================
RCS file: /cvsroot/src/sys/dev/nand/nand_bbt.c,v
retrieving revision 1.7
diff -p -u -r1.7 nand_bbt.c
--- sys/dev/nand/nand_bbt.c	22 Oct 2013 01:01:27 -0000	1.7
+++ sys/dev/nand/nand_bbt.c	7 Feb 2018 06:56:31 -0000
@@ -208,7 +208,7 @@ nand_bbt_block_mark(device_t self, flash
 	__USE(chip);
 	KASSERT(block < chip->nc_size / chip->nc_block_size);
 
-	clean = (~0x03 << ((block % 4) * 2));
+	clean = (0xfc << ((block % 4) * 2));
 	marker = (marker << ((block % 4) * 2));
 
 	/* set byte containing the 2 bit marker for this block */
Index: sys/dev/pci/if_et.c
===================================================================
RCS file: /cvsroot/src/sys/dev/pci/if_et.c,v
retrieving revision 1.15
diff -p -u -r1.15 if_et.c
--- sys/dev/pci/if_et.c	29 Jul 2017 01:47:48 -0000	1.15
+++ sys/dev/pci/if_et.c	7 Feb 2018 06:56:32 -0000
@@ -1224,8 +1224,7 @@ et_setmulti(struct et_softc *sc)
 			addr[i] &=  enm->enm_addrlo[i];
 		}
 
-		h = ether_crc32_be(LLADDR((struct sockaddr_dl *)addr),
-		    ETHER_ADDR_LEN);
+		h = ether_crc32_be(addr, ETHER_ADDR_LEN);
 		h = (h & 0x3f800000) >> 23;
 
 		hp = &hash[0];
Index: sys/dev/sun/kbd.c
===================================================================
RCS file: /cvsroot/src/sys/dev/sun/kbd.c,v
retrieving revision 1.68
diff -p -u -r1.68 kbd.c
--- sys/dev/sun/kbd.c	25 Jul 2014 08:10:39 -0000	1.68
+++ sys/dev/sun/kbd.c	7 Feb 2018 06:56:32 -0000
@@ -948,12 +948,13 @@ kbd_input_wskbd(struct kbd_softc *k, int
 #endif
 			case 0x30:
 #if NSYSMON_ENVSYS
-				if (k->k_isconsole)
+				if (k->k_isconsole) {
 					k->k_ev = KEY_UP(code) ?
 					    PSWITCH_EVENT_RELEASED :
 					    PSWITCH_EVENT_PRESSED;
 					sysmon_task_queue_sched(0,
 					    kbd_powerbutton, k);
+				}
 #endif
 				return;
 		}
Index: sys/external/bsd/ipf/netinet/ip_fil_compat.c
===================================================================
RCS file: /cvsroot/src/sys/external/bsd/ipf/netinet/ip_fil_compat.c,v
retrieving revision 1.4
diff -p -u -r1.4 ip_fil_compat.c
--- sys/external/bsd/ipf/netinet/ip_fil_compat.c	20 Mar 2014 20:43:12 -0000	1.4
+++ sys/external/bsd/ipf/netinet/ip_fil_compat.c	7 Feb 2018 06:56:32 -0000
@@ -2274,7 +2274,6 @@ frentry_4_1_0_to_current(ipf_main_softc_
 
 			if ((offset & 7) != 0)
 				offset += 8 - (offset & 7);
-				offset += 8 - (offset & 7);
 			error = ipf_in_compat(softc, &obj,
 					      fr->fr_names + offset, 0);
 			if (error == 0) {